feat: add test for overwriting replica values #166
+44
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsjoeio
changed the title
jsjoeio
changed the title
jsjoeio
commented
Nov 8, 2021
jsjoeio
commented
Nov 8, 2021
Comment on lines
+50
to
+53
| objs, err := RenderChart(chart, ValuesToOverwrite, nil, nil) | ||
| // TODO@jsjoeio - getting an error here | ||
| // error deserializing "coder/templates/coderd.yaml": yaml: line 9: mapping values are not allowed in this context | ||
| require.NoError(t, err, "failed to render chart") |
There was a problem hiding this comment.
@jawnsy I feel like I'm so close. I'm doing something wrong though and getting this error. Any ideas?
|
This is blocked until Jonathan and I fix bug in |
|
@jsjoeio I think this should be unblocked now, but may be kind of tricky as a lot of things have changed in the API. Might be best to reset your branch to the latest main and try again? |
ahh good to know! I'll restart this work hopefully next week 🤞 Thanks for letting me know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new test which tests for overwriting the replicas value in the default yaml template.
Fixes #165